[DRAFT] Add bulk logging of function invocations. misc DX #2223
+243
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tastycode
changed the title
tastycode
force-pushed
the
20240702-creative-debug-qol
branch
from
c34f169
to
30f87ad
Compare
There was a problem hiding this comment.
You'll need to use a black compatible with the workflow version (currently 24.4.2) to get the Python format check to pass - it looks like it picked up an actual bug in the format strings though.
I like libclang/libtooling as a basis for some stuff, though I'm a little concerned it'll add like 300 megabytes to the toolchain build next time we run it. Do you have an idea of the size it adds to the site-packages when installed?
scripts/tasks/task-annotate.py
Outdated
| with open(tags_file, "w+") as tags_file_pointer: | ||
| tags_file_pointer.write(result.stdout.decode('utf-8')) | ||
| else: | ||
| print(f"Failed to invoke {" ".join(ctags_invocation)}") |
There was a problem hiding this comment.
Suggested change
| print(f"Failed to invoke {" ".join(ctags_invocation)}") | |
| print(f"Failed to invoke {' '.join(ctags_invocation)}") |
Looks like the python format check picked up an actual bug in this format string.
scripts/toolchain/requirements.txt
Outdated
Comment on lines
6
to
7
| libclang |
There was a problem hiding this comment.
If we're going to add these dependencies they should be version locked.
m-m-adams
changed the title
tastycode
force-pushed
the
20240702-creative-debug-qol
branch
from
30f87ad
to
4b0f291
Compare
seangoodvibes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaving in draft while I get back up to speed the process for proposing changes. Most of this I wrote 6 months ago, but it was n't relevant enough to risk bundling it in with some other changes.
This is 2 additional DBT tasks along with supporting documentation changes and an additional macro. Nothing user facing.
while experiencing a bout of ADHD, I added a macro
D_POPUPwhich is a convenientsprintfenabled dev shortcut.D_POPUP("%d bottles of beer on the wall", 99)display->displayPopupis not available.