Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded subtitle soft #8915

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Oct 17, 2024

  1. Refactor subtitle addition process

    Enhance the process of adding subtitles to the ListView by refactoring the code and introducing asynchronous file processing. This includes consolidating redundant methods into a single method that generates the VideoPreviewGeneratorSub object and ensuring null values are handled. Improved user experience by setting the cursor to a wait state during background operations.
    
    Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
    ivandrofly committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1839166 View commit details
    Browse the repository at this point in the history
  2. Set wait message and cursor during file drag-and-drop

    Display a "please wait" message and change the cursor to a wait cursor when files are being processed in the drag-and-drop operation. Clear the message and reset the cursor once processing is complete.
    
    Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
    ivandrofly committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6cb3476 View commit details
    Browse the repository at this point in the history
  3. Add a progress bar for drag-and-drop operations

    Implemented a visible progress bar to give user feedback during drag-and-drop operations in the GenerateVideoWithSoftSubs form. This enhances the UI by indicating processing status and improving user experience.
    
    Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
    ivandrofly committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f0fba8c View commit details
    Browse the repository at this point in the history
  4. Remove unused variable from GenerateVideoWithSoftSubs

    This commit deletes the unused variable _inputVideoFileName from the GenerateVideoWithSoftSubs class. This cleanup improves code readability and reduces potential confusion during future maintenance.
    
    Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
    ivandrofly committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    81ed0c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Optimize subtitle list update

    Wrap subtitle list operations within BeginUpdate and EndUpdate calls to reduce UI flicker and improve performance during batch item insertions.
    
    Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
    ivandrofly committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4f2e0d1 View commit details
    Browse the repository at this point in the history
  2. Refactor wait state handling in drag-and-drop operation

    Extracted wait state activation and deactivation into separate methods: `ActivateWaitState` and `DeactivateWaitState`. This improves code readability and reduces repetition.
    
    Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
    ivandrofly committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6d8ce8d View commit details
    Browse the repository at this point in the history