Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XIVOmega Plugin #701

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

shingonati0n
Copy link

@shingonati0n shingonati0n commented Sep 24, 2024

XIVOmega

A Steam Deck Plugin (for Decky Loader) to mitigate latency on the Critically Acclaimed MMORPG Final Fantasy XIV. This plugin is the evolution of xivomega which in turn is based on XivMitmLatencyMitigator, XivMitmDocker and XivAlexander. Mitigation is done by using containers via Podman, which comes bundled with SteamOS.

20240923183757_1

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@shingonati0n
Copy link
Author

Hello, is there anything else I need to do to advance this request?? First time submitting a plugin,thanks. @TrainDoctor

@TrainDoctor
Copy link
Member

Hello, is there anything else I need to do to advance this request?? First time submitting a plugin,thanks. @TrainDoctor

Nothing that's your fault, apologies. Been busy with work and life and didn't get to many PRs, let alone yours 😅.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove the backend folder and it's contents as you don't appear to be using that functionality.
  2. Remove defaults.txt from the defaults folder.
  3. Remove decky_plugin.pyi as it is out of date and no longer used.
  4. Please update the license file to include your name or username (whichever is preferred).
  5. This is my fault, please update your lockfile to the latest (~v 9.0 etc) version. The plugin development side of the wiki was out of date and I only just updated that today.

Once you make these changes the plugin will be good to go to the testing store and once a testing report following the proper format (https://deckbrew.xyz/testing) is completed you'll be good to go to the production store!

@TrainDoctor TrainDoctor requested a review from a team October 13, 2024 18:49
@shingonati0n
Copy link
Author

Hi @TrainDoctor, changes have been made as requested. Note I also added a small update to main.py to handle an scenario I ran into recently (wlan0 not active at boot time). Please take a look, thanks!

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ TrainDoctor, changes have been made as requested. Note I also added a small update to main.py to handle an scenario I ran into recently (wlan0 not active at boot time). Please take a look, thanks!

Thanks, and sorry for the delay. Changes look good. Off to testing.

@TrainDoctor TrainDoctor requested review from a team October 22, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants