Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(volume names): approximate using onprem name #18

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Conversation

Jose-Matsuda
Copy link
Collaborator

@Jose-Matsuda Jose-Matsuda commented Nov 1, 2024

uses full hashed name to also avoid collisions as best as possible
BTIS-528
removes unused function

With this the max length reached is 53 characters

Copy link

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jose-Matsuda Jose-Matsuda merged commit ec3978c into master Nov 1, 2024
1 check passed
@Jose-Matsuda Jose-Matsuda deleted the upd-name branch November 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants