Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r-renv and clean up #694

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add r-renv and clean up #694

merged 2 commits into from
Nov 26, 2024

Conversation

bryanpaget
Copy link
Contributor

@bryanpaget bryanpaget commented Nov 18, 2024

I've added one package, r-renv, but in the process in merged these two mamba package installation blocks. See below code snippets.

We tend to have too many RUN blocks for packages.

RUN mamba install --quiet --yes \
      'r-rodbc' \
      'r-tidyverse' \
      'r-arrow' \
      'r-aws.s3' \
      'r-catools' \
      && \
      clean-layer.sh && \
      fix-permissions $CONDA_DIR && \
      fix-permissions /home/$NB_USER

# Install some default R packages
RUN mamba install --quiet --yes \
      'r-hdf5r' \
      'r-odbc' \
      'r-sf' \
      'r-e1071' \
      'r-markdown' \
    && \
    clean-layer.sh && \
    fix-permissions $CONDA_DIR && \
    fix-permissions /home/$NB_USER

So I merged these two into one.

# Install some default R packages
RUN mamba install --quiet --yes \
      'r-arrow' \
      'r-aws.s3' \
      'r-catools' \
      'r-e1071' \
      'r-hdf5r' \
      'r-markdown' \
      'r-odbc' \
      'r-renv' \
      'r-rodbc' \
      'r-sf' \
      'r-tidyverse' \
    && \
    clean-layer.sh && \
    fix-permissions $CONDA_DIR && \
    fix-permissions /home/$NB_USER

@bryanpaget bryanpaget added the auto-deploy Trigger manual CI steps for this PR label Nov 18, 2024 — with GitHub Codespaces
@bryanpaget bryanpaget changed the title merge two mamba blocks, add r-renv, sort packages Add r-renv and cleanup Nov 18, 2024
@bryanpaget bryanpaget changed the title Add r-renv and cleanup Add r-renv and clean up Nov 18, 2024
@bryanpaget bryanpaget self-assigned this Nov 19, 2024
@Souheil-Yazji
Copy link
Contributor

Don't forget to check upstream images for r-env

Copy link
Contributor

@Souheil-Yazji Souheil-Yazji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanpaget bryanpaget merged commit 9c17679 into master-2.0 Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants