Skip to content

Commit

Permalink
fix: receive as secrets again
Browse files Browse the repository at this point in the history
  • Loading branch information
EveningStarlight committed Nov 29, 2024
1 parent fa21e63 commit 869f483
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
12 changes: 2 additions & 10 deletions .github/workflows/docker-build-test-upload.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@ on:
required: false
type: string
default: default
registry-username:
description: Username for the ACR
required: true
type: string
registry-password:
description: Password for the ACR
required: true
type: string

jobs:
build-test-upload:
Expand Down Expand Up @@ -62,8 +54,8 @@ jobs:
- uses: azure/docker-login@v1
with:
login-server: ${{ env.REGISTRY_NAME }}.azurecr.io
username: ${{ inputs.registry-username }}
password: ${{ inputs.registry-password }}
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}

# make build emits full_image_name, image_tag, and image_repo outputs
- name: Build image
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ jobs:
parent-image: ""
image: "base-cpu"
secrets:
registry-username: ${{ secrets.REGISTRY_USERNAME }}
registry-password: ${{ secrets.REGISTRY_PASSWORD }}
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}

0 comments on commit 869f483

Please sign in to comment.