retry image retagging for 300 seconds #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does someone know an easy way, to really test this? |
staust
changed the title
ricoberger
approved these changes
Sep 18, 2024
You can use the branch in your repository with |
cstaud
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Retry the image retagging for releases for atleast 5 min. This should reduce cd failures when you merge to main and immediately trigger a release like here: https://github.com/Staffbase/customer-control/actions/runs/10773567525/job/29873909087#step:4:322
Checklist
I could imagine some rare edge cases when you trigger two releases within those 5 minutes of retry where the false image gets the latest tag. I dont know if this is relevant.