Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub logo and link to the website repo #286

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

DannyGarciaDEV
Copy link
Contributor

@DannyGarciaDEV DannyGarciaDEV commented Jun 28, 2024

PR Checklist

Overview

Description

Added GitHub icon to website header for enhanced navigation.

Changes Made

  • Created GitHubLogo.tsx component to render GitHub icon.
  • Updated SocialsList.tsx to include GitHubLogo component for displaying GitHub link in the socials list.

How it Works

The new GitHub icon now appears in the website header, linking users directly to the project's GitHub repository.
CodeTS

Related Issues

@astorije
Copy link
Collaborator

This is great, thank you for the timely contribution! Where did you obtain the SVG code for the GitHub logo?

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Jun 30, 2024
@astorije
Copy link
Collaborator

Hey @DannyGarciaDEV, are you planning on addressing the comments on this PR? 🙏

@DannyGarciaDEV
Copy link
Contributor Author

Sorry I just saw this messages! I got it from here but i had to do some changes https://iconmonstr.com/github-1-svg/

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boston-ts-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:59am

@astorije
Copy link
Collaborator

No worries, thanks! I committed my suggestion so make sure to run git pull before making any new commits.

Re: logo, what changes have you had to make? Could we instead use the SVG from https://github.com/logos as it's the official one?

@astorije
Copy link
Collaborator

Hey @DannyGarciaDEV, quick follow-up, would you like me to take over this PR? No pressure of course :)

@DannyGarciaDEV
Copy link
Contributor Author

@astorije I am gonna be working this days on it i was a little busy the passed few weeks!

Co-authored-by: Jérémie Astori <jeremie@astori.fr>
@astorije astorije changed the title creating github logo for boston ts club feat: add GitHub logo and link to the website repo Jul 25, 2024
@astorije astorije removed the status: waiting for author Needs an action taken by the original poster label Jul 25, 2024
Copy link
Collaborator

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you @DannyGarciaDEV!

@astorije astorije merged commit 5bde5c4 into SquiggleTools:main Jul 26, 2024
11 checks passed
@JoshuaKGoldberg
Copy link
Member

@all-contributors please add @DannyGarciaDEV for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Documentation: GitHub Icon on Homepage
3 participants