Part 1: infra changes #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part 1 branch
JonEsparaz
requested changes
Dec 16, 2023
There was a problem hiding this comment.
Thanks for the PR, @AlexandreOndet.
A few comments to be addressed and a few questions, which might spawn some addition items that need to be fixed.
Additionally, please add some details to the PR description. At minimum please:
- Document what the code and config introduced in this PR does
- State how this PR should be tested
| @@ -0,0 +1,134 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Is there a particular reason why this is a bash script?
I feel that a Python script would be more readable for most people. I would expect that the environment that this script will be run on (either CI or a developer's machine) would have Python install.
| @@ -0,0 +1,13 @@ | |||
| FROM node:16-alpine AS development | |||
There was a problem hiding this comment.
Again, Node v20 would be preferred.
Additionally, is there a reason why you're using an Alpine image? Alpine can be the cause of many issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a first step for merging #50.
The new files introduced in this PR allow to :
Since this PR contain mostly config files, running the project is the test.