Added command to force config update (untested) #6
Conversation
|
Wouldn't it be much simpler to have the script just set the convars to the new values in the config file instead? Would avoid a restart. |
|
It would also have to add the new config into the config table. Also, I made this alteration because for some reason ours didn't recognize discord as the primary identifier on boot, and we were mid session trying to fix it so we couldn't initiate a server restart at that time. But the flag had already set it as a critical error and stopped everything from running. I would assume to clear the critical flag and allow the script to run again would only be via restart. |
|
It would require fixing whatever caused it to error then just restarting the resource, as that failure mode is just a boolean set against the Config table (and not set as a convar). You can also manually change the variables in the console (via set) then restart the resource. None of these would require a whole server restart, though. |
|
That's what we ended up doing the other night but it wasn't until I went through the entire configuration code base to figure out it would work. This PR is just for simplicity if it ever happens in the future. |
Wanted to add a way to force the config to clear, I'm not sure if I did this right but from what I gathered on restart it checks the convars to see if it was set on startup. This would only look for convars set by the framework to clear and set them to none.