Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short term/code optimization #83

Merged
merged 15 commits into from
Jun 28, 2024
Merged

Conversation

SmartGecko44
Copy link
Owner

@SmartGecko44 SmartGecko44 commented Jun 27, 2024

Pull Request

Description

Please provide a brief description of the changes introduced by this pull request.

  • scaleReverseLogic now takes the cleanRemove method as an argument in preperation of the removal of the "source" variable.
  • sped up the removal and cleaned up the code
  • ran an automatic code cleaner
  • SetRadiusLimitCommand now displays the old radius, as well as the new radius
  • updated the pull request template
  • updated nbt-api to 2.13.1 (Bump de.tr7zw:item-nbt-api from 2.12.4 to 2.13.1 #85)
  • Removed usage of deprecated functions

Checklist

Please review and check the following before submitting your pull request:

  • I have read and followed the Contributing Guidelines.
  • My code follows the established Code Style.
  • I have added appropriate comments and documentation.
  • My changes pass the continuous integration tests.
  • I have reviewed and updated the documentation if necessary.
  • I have checked for and resolved any merge conflicts.
  • I have tested my changes locally.
  • My code does not significantly impact the performance of any existing features in a negative way.

Security

Please ensure that your changes adhere to our Security Policy and do not introduce security vulnerabilities.

  • My code does not house any security vulnerabilities, backdoors or any other malicious code.

By submitting this pull request, I confirm that my contribution is made under the terms of the project's LICENSE.

@SmartGecko44 SmartGecko44 added this to the Version 7.0.0 milestone Jun 27, 2024
@SmartGecko44 SmartGecko44 added enhancement New feature or request minor update Small qol improvements labels Jun 27, 2024
@SmartGecko44 SmartGecko44 marked this pull request as ready for review June 27, 2024 20:30
@SmartGecko44
Copy link
Owner Author

NBT-api has depreciated an integral part of the item identification 😭

dependabot bot and others added 5 commits June 27, 2024 20:55
Bumps de.tr7zw:item-nbt-api from 2.12.4 to 2.13.1.

---
updated-dependencies:
- dependency-name: de.tr7zw:item-nbt-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.10.2 to 5.10.3.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.10.2...r5.10.3)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…upiter-junit-jupiter-5.10.3

Bump org.junit.jupiter:junit-jupiter from 5.10.2 to 5.10.3
…em-nbt-api-2.13.1

Bump de.tr7zw:item-nbt-api from 2.12.4 to 2.13.1
Copy link

sonarcloud bot commented Jun 28, 2024

@SmartGecko44 SmartGecko44 merged commit 25b51f0 into master Jun 28, 2024
4 checks passed
@SmartGecko44 SmartGecko44 deleted the short-term/code-optimization branch June 28, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor update Small qol improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant