implement autocompleteDropDownMenu #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyyo
requested changes
May 21, 2022
app/src/main/java/com/skyyo/samples/features/autoComplete/CustomExposedDropdownMenuSample.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/skyyo/samples/features/autoComplete/CustomExposedDropdownMenuSample.kt
Outdated
Show resolved
Hide resolved
Skyyo
requested changes
Jun 4, 2022
.../main/java/com/skyyo/samples/features/autoComplete/AndroidViewTextFieldWithDropDownSample.kt
Outdated
Show resolved
Hide resolved
Skyyo
requested changes
Jun 14, 2022
There was a problem hiding this comment.
- pushed small cleanup commit to your branch.
NativeExposedDropDownMenuSample->AutocompleteDropdownWithFilteringInsideCustomExposedDropdownMenuSample->AutocompleteDropdownWithOutsideFilteringAndroidViewTextFieldWithDropDownSample->AndroidViewAutocompleteDropdownWithOutsideFiltering- Not sure why we have 2x
AndroidViewTextFieldWithDropDownSample, Unless there is something to showcase, let's please leave single one @RostyslavKloos NativeExposedDropDownMenuSamplehas noticeable lag when filtering. Also it doesn't suggest new items upon cleaning the field from input. Attaching video https://photos.app.goo.gl/qXYymgfE7JZZtVMd7
| } | ||
| } | ||
| } | ||
| val autoCompleteTextView = remember { textInputLayout.editText as? AutoCompleteTextView } |
There was a problem hiding this comment.
- I wanted to demonstrate how it should behave depends on layout position. But yeah, it's not necessary
- That's true. But this is how compose implementation of autocomplete works now and that's why I created own implementation which not lagging.
about suggestions - I'll check
Skyyo
requested changes
Jul 20, 2022
There was a problem hiding this comment.
- The biggest issue is still lagging, which causes ANR.
- There is empty dropdown in certain scenarios.
Video describing the above. - Not sure what's the difference between two "AndroidViews".
- Not sure what's the difference between "native exposed dropdown menu" and "custom exposed dropdown menu"
Comment on lines
29
to
40
| viewModelScope.launch(Dispatchers.Default) { | ||
| handle[SUGGESTIONS] = if (input.isEmpty()) { | ||
| countries.also { onExpandedChange(false) } | ||
| } else { | ||
| val filteredList = countries.filter { country -> | ||
| country | ||
| .lowercase() | ||
| .startsWith(input.lowercase()) && country != input | ||
| } | ||
| filteredList.also { onExpandedChange(true) } | ||
| } | ||
| } |
There was a problem hiding this comment.
work is not done on BG thread. you need to use the withContext
There was a problem hiding this comment.
viewModelScope.launch(Dispatchers.Default) { doWork }
viewModelScope.launch { withContext(Dispatchers.Default) { doWork }
isn't it the same thing?
about questions above
- Yes. and I can't do anything with it. check please 3 point with detail explanation
- done fixing
- No difference, I'll remove one of them
native exposed dropdown menu-> current implementation by jetpack compose which works very bad with large list of data, because it uses column instead of lazyColumn under hood. that's why you can see lags, which causes ANR, because I used large list of data. And i added this sample on screen especially to show that lagging compare toAndroidViewandcustom implementation
custom exposed dropdown menu-> my implementation. which based on implementation by jetpack compose. (so I just copy pasted most of code) The main work I did - replace column with lazyColumn which causes all the problems with lags.
Comment on lines
33
to
37
| val filteredList = countries.filter { country -> | ||
| country | ||
| .lowercase() | ||
| .startsWith(input.lowercase()) && country != input | ||
| } |
There was a problem hiding this comment.
seems we are not using filteredList anywhere
There was a problem hiding this comment.
we actually use:
handle[SUGGESTIONS] = if (input.isEmpty()) countries else ... filteredList
| .lowercase() | ||
| .startsWith(input.lowercase()) && country != input | ||
| } | ||
| filteredList.also { onExpandedChange(true) } |
There was a problem hiding this comment.
is there any reason not to do filteredList.also { onExpandedChange(true) } -> onExpandedChange(true) ?
Comment on lines
+36
to
+38
| val textFieldValue = remember { | ||
| mutableStateOf(TextFieldValue(query, TextRange(query.length))) | ||
| } |
There was a problem hiding this comment.
shouldn't we use query as a key here?
| modifier: Modifier = Modifier, | ||
| countries: List<String>, | ||
| ) { | ||
| val coroutineScope = rememberCoroutineScope() |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvements compare to "exposedDropDown" implementation:
differences compare to "androidView" implementation:
2022-05-18.12.58.48.mp4