-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scheduling logic #25
Conversation
8932359
to
729413a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments and thoughts. In general it looks fine, there's a few clarifications (around App vs App Set, test cases, etc.) that might be needed and minor suggestions on comments and naming.
Co-authored-by: Diogo Campos <d.diogocampos@gmail.com>
One more comments, on https://github.com/Skyscanner/argocd-progressive-rollout/pull/25/files#diff-b1a5cf22f2be07477047c7c268c9a2077f75c3fdadc285eb862dab8bc3aaad31R293 I am not sure if there are standards around that specifically for operators, but generally speaking when dealing with structures that have a degree of identity to it (typically, an Application has an identity, it's deploying something to somewhere, and nothing else does that), Go tends to push you towards using pointer semantics. |
I was using pointers where I was doing in-place update of a data structure, this is why we have Regarding pointers vs value, I was using the majority of value because I thought it was easier to understand and I don't see any downside for our workload. |
As discussed, would be good to have a wider conversation about it, as it'll cause some potentially heavy refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, adds a scheduling capability to the reconcile
Co-authored-by: Diogo Campos <d.diogocampos@gmail.com>
Fix #20
Notes:
Owns
, because then when we readpr.Owns(app.GetOwnersReference())
is clear that the Progressive Rollout owns the Applicationutils
functions with their testsshould reconcile
integration test to work with the scheduler