Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for invalid ClassDefinitionTable offset handling #360

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This fixes an issue discovered in the Stimulsoft forums linked from #354. The font contains an invalid offset to the ClassDefinitionTable. I've tested rendering the font and output is as expected when we return null.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #360 (85dd84f) into main (429d527) will increase coverage by 0%.
Report is 1 commits behind head on main.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main    #360   +/-   ##
=====================================
  Coverage     86%     86%           
=====================================
  Files        238     238           
  Lines      15171   15182   +11     
  Branches    2100    2100           
=====================================
+ Hits       13073   13085   +12     
  Misses      1613    1613           
+ Partials     485     484    -1     
Flag Coverage Δ
unittests 86% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Tables/AdvancedTypographic/AttachmentListTable.cs 100% <100%> (ø)
...Tables/AdvancedTypographic/ClassDefinitionTable.cs 95% <100%> (+1%) ⬆️
...Tables/AdvancedTypographic/GlyphDefinitionTable.cs 84% <100%> (+1%) ⬆️
...s/Tables/AdvancedTypographic/MarkGlyphSetsTable.cs 100% <100%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@JimBobSquarePants JimBobSquarePants merged commit 63db8ad into main Sep 25, 2023
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/optional-cdf-load branch September 25, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants