Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: ✨ fixes issue #267. show 0 hr and 24 hr markers in timeline. #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ParthBaraiya
Copy link
Collaborator

@ParthBaraiya ParthBaraiya commented Jun 6, 2024

Description

Added support to show end hours i.e. 0 hr and 24 hr marker in DayView and WeekView.

Screenshot 2024-06-07 at 12 05 47 PM

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Migration instructions

Updated syntax for timeStringBuilder and timeLineBuilder in DayView and WeekView.

// Old
DayView(
    ...,
    timeStringBuilder: (date) => "",
    timeLineBuilder: (date) => SizedBox(),
);

// New
DayView(
    ...,
    timeStringBuilder: (time, date) => "",
    timeLineBuilder: (time, date) => SizedBox(),
);

We have introduced a new parameter, TimeOfDay, to represent time in 24-hour. Using DateTime for this purpose was inconvenient, as setting the hour to 24 would change the day and reset the hour to 0. The TimeOfDay parameter avoids this issue and provides a straightforward way to handle 24-hour time representations. Users who need to work with day, month, or year can still use the DateTime parameter as needed.

Related Issues

Closes #267

@PRBaraiya PRBaraiya force-pushed the feature/issue-267-show-end-hours branch 3 times, most recently from f404f75 to 0a94526 Compare June 13, 2024 14:12
@PRBaraiya PRBaraiya force-pushed the feature/issue-267-show-end-hours branch from 0a94526 to eb0feb8 Compare July 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paint TimeLine from 00:00
1 participant