Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RTL in HourLine Painters #265

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MohamedGawdat
Copy link

@MohamedGawdat MohamedGawdat commented Sep 16, 2023

Description

  • Introduced RTL support for the custom painters (HourLinePainter) to cater to Arabic languages and other RTL layouts.
  • Refactored dashed line logic to remove redundancy and improve readability.
  • Updated the shouldRepaint methods to include checks for all relevant properties.

This enhancement ensures our UI components are more versatile and can be used seamlessly in both LTR and RTL applications.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@MohamedGawdat MohamedGawdat changed the title Support for RTL in HourLine and HalfHourLine Painters Support for RTL in HourLine Painters Sep 17, 2023
@PRBaraiya
Copy link
Collaborator

Hi @MohamedGawdat , Please resolve merge conflicts in this PR.

Gawdat added 3 commits November 27, 2023 15:25
# Conflicts:
#	lib/src/day_view/_internal_day_view_page.dart
#	lib/src/day_view/day_view.dart
#	lib/src/painters.dart
#	lib/src/week_view/_internal_week_view_page.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants