Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refine multiselect API #784

Merged
merged 1 commit into from
Oct 28, 2024
Merged

refactor: refine multiselect API #784

merged 1 commit into from
Oct 28, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Oct 18, 2024 •
edited
Loading

changes

  • This PR refines the multiselect API with learnings from adding it to the more complex files use-case in the subsequent PR.
  • Selection is now via clicking anywhere on a table row rather than a special checkbox control.
  • Table row data now supports an isSelected prop.
  • The keys table now has pagination controls.

@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:57pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 7:57pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 7:57pm
hostd ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 7:57pm
website ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 7:57pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b32b1c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@siafoundation/design-system Minor
renterd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Oct 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexfreska alexfreska mentioned this pull request Oct 18, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 1a9941b to 70ee5a4 Compare October 18, 2024 20:40
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 70ee5a4 to 7ee383a Compare October 18, 2024 21:54
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 7ee383a to 231777c Compare October 23, 2024 12:15
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 231777c to 3a8a307 Compare October 24, 2024 14:30
@alexfreska alexfreska mentioned this pull request Oct 24, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 3a8a307 to 9f70583 Compare October 24, 2024 14:59
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 9f70583 to 6c8467f Compare October 24, 2024 19:51
@alexfreska alexfreska changed the base branch from main to test_e2e_restore_cluster_install_latest October 24, 2024 19:51
This was referenced Oct 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@alexfreska alexfreska mentioned this pull request Oct 24, 2024
Merged
@alexfreska alexfreska force-pushed the test_e2e_restore_cluster_install_latest branch from 629c806 to 3ca09a8 Compare October 25, 2024 16:47
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 5454520 to b8ff760 Compare October 25, 2024 19:36
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from b8ff760 to b32b1c7 Compare October 25, 2024 19:43
telestrial
telestrial approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@telestrial telestrial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put this here, but it may be solved in a stacked PR or even already done in production: is the user made aware of this feature visually before clicking? Could be a cursor change and/or a hover backgroundColor change--anything that would invite them into the multiselect feature outside of the checkbox context.

@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Oct 28, 2024 •
edited
Loading

@telestrial this is a good point, currently there is the select all page checkbox which gives a hint, and then the cursor pointer on the table rows, so the user may try clicking after which things should be clear, but I think we could do a little more, maybe a bit more hover state as you suggest. Let me know if you have any ideas as you play with the apps going forward.

@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Oct 28, 2024 •
edited
Loading

Merge activity

  • Oct 28, 1:15 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 28, 1:16 PM EDT: A user merged this pull request with Graphite.

@alexfreska alexfreska merged commit 0914286 into main Oct 28, 2024
37 checks passed
@alexfreska alexfreska deleted the refactor_refine_multiselect_api branch October 28, 2024 17:16
This was referenced Oct 29, 2024
Merged
Merged
Merged
This was referenced Nov 20, 2024
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telestrial telestrial telestrial approved these changes

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @telestrial