WIP assertion on json type with a floating point value with zero fractional part #353
+59
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional part Go test (passes): `DEBUG=1 go test ./... -v -run='TestDMLEventsTestSuite'` Ruby integration test (fails): ``` DEBUG=1 bundle exec ruby test/main.rb -v -n "TypesTest#test_json_data_update" && DEBUG=1 bundle exec ruby test/main.rb -v -n "TypesTest#test_json_data_insert" ``` This means that if the right value is supplied to the ghostferry types, it generates the correct statement (hence the go unit test passes) but if it gets bad values from the go-mysql-org library, it fails as expected.
|
handled in #368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tional part
Go test (passes):
DEBUG=1 go test ./... -v -run='TestDMLEventsTestSuite'Ruby integration test (fails):This means that if the right value is supplied to the ghostferry types, it generates the correct statement (hence the go unit test passes) but if it gets bad values from the go-mysql-org library, it fails as expected.