Don't notify Slack if main fails due to workflow cancellation #4913
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
.github/workflows/shopify-cli.yml
Outdated
| @@ -90,7 +90,7 @@ jobs: | |||
| run: pnpm nx run features:test | |||
| - name: Send Slack notification on failure | |||
| uses: slackapi/slack-github-action@007b2c3c751a190b6f0f040e47ed024deaa72844 # pin@v1.23.0 | |||
| if: failure() | |||
| if: ${{ failure() && github.event.workflow_run.conclusion != "cancelled" }} | |||
There was a problem hiding this comment.
The workflow run context variable github.event.workflow_run.conclusion isn't accessible in this job. To detect a cancelled workflow, use github.run.conclusion instead:
if: ${{ failure() && github.run.conclusion != 'cancelled' }}Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
amcaplan
force-pushed
the
dont-bother-about-broken-workflows-if-just-cancelled
branch
from
362ec30
to
ebadc00
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1961 tests passing in 890 suites. Report generated by 🧪jest coverage report action from ebadc00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Stops seeing notifications that aren't necessary.
This usually happens due to PRs being merged in quick succession, so an earlier workflow gets cancelled. This is just useless noise.
WHAT is this pull request doing?
Only runs the Slack notification step if the workflow failed, not if it was cancelled.
How to test your changes?
Gotta test in prod
Measuring impact
How do we know this change was effective? Please choose one:
Checklist