[Themes] Theme Dev - Display theme asset upload errors in overlay

[jamesmengo]

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[jamesmengo]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [Themes] Theme Dev - Display theme asset upload errors in overlay #4899 👈 (View in Graphite)
• Add --strict flag to theme push to enforce theme check before pushing #4900
• Ensure git directory is clean when running theme pull #4905
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	74.56% (+0.01% 🔼)	8554/11473
🟡	Branches	70.34% (+0.02% 🔼)	4172/5931
🟡	Functions	74.11% (+0.01% 🔼)	2247/3032
🟡	Lines	75.1% (+0.01% 🔼)	8090/10772

Test suite run success

1951 tests passing in 887 suites.

Report generated by 🧪jest coverage report action from 8211225

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/git.d.ts

@@ -97,6 +97,13 @@ export declare class OutsideGitDirectoryError extends AbortError {
  * @param directory - The directory to check.
  */
 export declare function ensureInsideGitDirectory(directory?: string): Promise<void>;
+/**
+ * Returns true if the given directory is inside a .git directory tree.
+ *
+ * @param directory - The directory to check.
+ * @returns True if the directory is inside a .git directory tree.
+ */
+export declare function insideGitDirectory(directory?: string): Promise<boolean>;
 export declare class GitDirectoryNotCleanError extends AbortError {
 }
 /**

packages/cli-kit/dist/public/node/themes/types.d.ts

@@ -15,6 +15,7 @@ type ThemeFSEvent = {
     type: 'add' | 'change';
     payload: {
         fileKey: Key;
+        uploadErrors: Map<Key, string[]>;
         onContent: (fn: (content: string) => void) => void;
         onSync: (fn: () => void) => void;
     };
@@ -93,6 +94,14 @@ export interface ThemeFileSystem extends VirtualFileSystem {
     applyIgnoreFilters: <T extends {
         key: string;
     }>(files: T[]) => T[];
+    /**
+     * Map of file keys to errors.
+     */
+    uploadErrors: Map<string, string[]>;
+    /**
+     * Emits an event to the event emitter.
+     */
+    emitEvent: <T extends ThemeFSEventName>(eventName: T, payload: ThemeFSEventPayload<T>) => void;
 }
 /**
  * Represents a theme on the file system.