Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Support app-management only mode #4880

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Nov 19, 2024

WHY are these changes introduced?

Related to https://github.com/Shopify/develop-app-inner-loop/issues/2280

WHAT is this pull request doing?

How to test your changes?

  • Start identity, shopify and business-platform locally
  • SHOPIFY_CLI_NEVER_USE_PARTNERS_API=1 USE_APP_MANAGEMENT_API=1 SHOPIFY_SERVICE_ENV=local p shopify app deploy

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

shauns commented Nov 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shauns shauns changed the title Support app-management only mode [DNM] Support app-management only mode Nov 19, 2024
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -17,6 +17,7 @@ export declare const environmentVariables: {
     verbose: string;
     noThemeBundling: string;
     bundledThemeCLI: string;
+    neverUsePartnersApi: string;
     codespaces: string;
     codespaceName: string;
     codespacePortForwardingDomain: string;
packages/cli-kit/dist/public/node/environment.d.ts
@@ -43,4 +43,10 @@ export declare function getIdentityTokenInformation(): {
     accessToken: string;
     refreshToken: string;
     userId: string;
-} | undefined;
\ No newline at end of file
+} | undefined;
+/**
+ * If true, the CLI should not use the Partners API.
+ *
+ * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
+ */
+export declare function blockPartnersAccess(): boolean;
\ No newline at end of file

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.52% (-0% 🔻)
8553/11477
🟡 Branches
70.39% (-0.01% 🔻)
4184/5944
🟡 Functions
73.93% (+0.01% 🔼)
2246/3038
🟡 Lines
75.04% (-0% 🔻)
8089/10779
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / developer-platform-client.ts
55.26% (-0.62% 🔻)
44.44% (+1.59% 🔼)
70%
54.84% (-0.72% 🔻)
🟢
... / fqdn.ts
84.44% (-1.6% 🔻)
84.62% (-2.88% 🔻)
87.5%
84.44% (-1.6% 🔻)

Test suite run success

1952 tests passing in 886 suites.

Report generated by 🧪jest coverage report action from d2b5fb7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant