Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename theme-app-extension-next to theme-app-extension #4593

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented Oct 7, 2024

WHY are these changes introduced?

Follow up on - #4592

Renames a file that was deleted in the previous PR (replacing theme-app-extension with theme-app-extension-next)

I split this into a different PR to avoid polluting the diff of this change

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

@jamesmengo jamesmengo force-pushed the jm/remove-ruby/appdev branch 2 times, most recently from cbf552a to 40749eb Compare October 8, 2024 00:10
@jamesmengo jamesmengo self-assigned this Oct 8, 2024
@jamesmengo jamesmengo added the #gsd:40767 Fortify local development experience for Liquid themes label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.81% 8552/11746
🟡 Branches 69.77% 4200/6020
🟡 Functions 71.81% 2209/3076
🟡 Lines 73.14% 8095/11068
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / theme-app-extension.ts
93.75% 90% 83.33% 93.55%

Test suite run success

1947 tests passing in 876 suites.

Report generated by 🧪jest coverage report action from d7671f9

@karreiro karreiro marked this pull request as ready for review October 16, 2024 16:16
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jamesmengo!

@jamesmengo jamesmengo merged commit e7d58bf into jm/remove-ruby/appdev Oct 16, 2024
37 checks passed
@jamesmengo jamesmengo deleted the jm/remove-ruby/appdev-rename branch October 16, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:40767 Fortify local development experience for Liquid themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants