[Theme] Avoid breaking the document on Liquid syntax error #4583
+6
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4548
We were prettifying Liquid syntax errors to make them more obvious. The problem is that, in doing so, we were breaking the rest of the documents if the Liquid syntax error ocurred within CSS or an HTML attribute. This affected themes that had inadvertent Liquid errors. The Ruby CLI would just display the Liquid error within the HTML attribute, making it virtually invisble, while the new CLI would make it obvious and break the rest of the document.
We might reintroduce the Liquid error prettifyier / surface them with an overlay or something that doesn't affect the rest of the document, so that it is obvious you have Liquid errors.
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist