Warn less often about scope mismatch #4574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We show a warning if we think the developer may have forgotten to run deploy prior to dev, in particular if the developer has changed their app scopes in their local TOML file, but they're out of sync with what is found remotely. There are cases where this check is giving a false alarm.
WHAT is this pull request doing?
Normalise the scope strings before comparing them.
How to test your changes?
Tricky one... there's an automated test. And we have an internal app that has one of these false alarms that I'm happy to share once we have a testable patch in place.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist