feat: updates via websockets #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a POC I made with a modified version of the mlogjs web editor websockets_demo.mp4 |
This change greatly reduces the likelyhood of the websocket server not being closed properly when the game is closed
This reverts commit 737d963.
This is the recommended way to define the config screen of a mod
This change updates the config page to let users set the websocket server's port and restart it, as well as restoring mod options to their defaults
This event is fired by the game before it is closed, this allows the mod to clean up the used resources in a much more consistent way.
|
The pull request is pretty much done, but both the korean and english bundles require some attention, one needs to be updated and the other needs to be checked to see if it is clear and concise enough. |
|
thanks for your contribution! i'll test PR build mod today and merge it. @JeanJPNM |
|
@JeanJPNM is your demo released already? i cannot test on your unreleased mlogjs web editor |
|
You have to go to the pull request's preview link: https://deploy-preview-221--mlogjs.netlify.app/editor.html |
|
it works on my machine too. thanks for your contribution very much. the PR will be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements update functionality via a websocket connection.
Closes #2.
Todo: