Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive cat item owner #159

Conversation

Rampriya-S
Copy link
Contributor

We should ensure that inactive users are removed from being assigned as Catalog item owners

@Rampriya-S
Copy link
Contributor Author

Hi Reviewers, I have deleted #153 as you advised. I had one update in all my pull requests: #154, #155, #156, # 157, and #158. like the below screen shot, which you have closed
image

Every time I want to contribute, I'm deleting my fork or syncing, but all the time my pull requests are rejected and closed.

@SapphicFire
Copy link
Contributor

Hi! In your screenshot you have selected a single commit, but both the commit and the files changed section show 9 total commits (and file updates).

If you are on SNDevs.slack.com, please reach out on #hacktoberfest and people there can provide guidance. Additionally, the process is discussed here: https://git-scm.com/book/en/v2/Git-Branching-Basic-Branching-and-Merging

At the moment, you are adding branches and commits on top of each other instead of starting from the main branch again. See these images and excuse my drawing skills

Current:
image

What we need:
image

@SapphicFire
Copy link
Contributor

If we accepted this in its current state, we wouldn't be capturing your submission of 8 seperate checks which is why we ask people to break these down into individual branches.

Additionally, you have not included the required readme updates

@SapphicFire SapphicFire self-assigned this Oct 21, 2024
@SapphicFire
Copy link
Contributor

As there has been no response from you @Rampriya-S I will close this for now but please review the above so you can avoid these challenges in future! 😄

@Rampriya-S
Copy link
Contributor Author

@SapphicFire Apologize, I have been occupied with multiple works; let me try it by this weekend. Thank you for your guidance & drawings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants