Skip to content

Commit

Permalink
Avoid usage of gs.log() (#146)
Browse files Browse the repository at this point in the history
* Highly recommended practice to use ATFs for regression testing  on instance upgrade and releases.

* Use Logging Levels: Instead of gs.log(), consider using more appropriate logging levels, such as:
gs.info() for informational messages.
gs.warn() for warnings that don’t break functionality but may need attention.
gs.error() for logging errors that require investigation.

* Update README.md

---------

Co-authored-by: Laszlo <47461634+Lacah@users.noreply.github.com>
  • Loading branch information
Rampriya-S and Lacah authored Oct 20, 2024
1 parent 91c4c82 commit ed3e217
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 1 deletion.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ Open-Sourced community contributed and owned repository for Instance Scan Defini

## Category: Manageability

###Avoid gs.log()Statement
Use Logging Levels: Instead of gs.log(), consider using more appropriate logging levels, such as:
gs.info() for informative messages.
gs.warn() for warnings that don’t break functionality but may need attention.
gs.error() for logging errors that require investigation.

### Create ATFs in sub production instance
Highly recommended practice to use ATFs for regression testing on instance upgrade and releases.

Expand Down
2 changes: 1 addition & 1 deletion ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2GmWsJ-o1b3QV3-6URGiSXSMI8C_MGtuzUzllO-E25BLlW8xY3T33MhCEIjrlR3Iagmuub4YikspwkRRYc_er66_c1onVimbRiN2socYSYWwCzxsJwJ_42oE5oqKePrOLryz7_pU_jzxOYRNa0xBvwEidli_M_kIXOSrwXflcA6Y_bMzciNW2YcnLDxK96tAoSooIaBQEw4x7xKxIIE-ejLeYlU6l11ELhmCn_wOXE-PnAkBU643SDLxBxPp8qsDW791X4ZPOM5_iL6U7Bdtrvb6Kn6mcHZNPFLJC8q7IrJ0wv19MuJlQp-Zi0BH9dg-oN6s5cIKOHYFiINFgINPK2wNocUSVJERDkqoHZOCq0T69m0FxKrEh3B4zujM0zgqx0uXCHVDK08hAyEGISYo7xFU6rUBZhBzLtaVLNHmOOlXlka3h9t8B9mEjYaBcInBbwzMwSgmTIYtN_GuwVekOY-L8R6Iz8ni3sNTd7s36vHxzmSKy0KHMRmzLCS7x8ig1LROAn2UWlX_yrv7AUtwSi1ENYOxw7ayF6mCwxU37FECms1bZVOJWpnfZtQH86cSsZc0FNGyswWUFJRi-XIS0fQA-zl7NVpElIJBONXSK_16Y3uTMx-nr3M5zOiQK5VBUN5SsAGfDucfu-VVwM9-O5HUSs_LGuA9J1Pt4xqKj-8
FFSb285LVQLVwwSy1sN9TSS_xgKMdxMueRetT0HDGeIrQsCSVVqvJzq4M3L_pFYItVzRNDhnJyUVmYX7kiDXTToGUlLA1bTP6qfEDtDOKAjH87dpFAYY0oCn-BigJNe6f5mwNAGVBXr3LuZsGmtUK_ximdlxUEYd2DZxoRROrqzIDgwXIAvh0-j8KEYoBGFnBral4LH5FhuzlJImUAh098OvSvclL5NbEYBf4VBqcQZvIP0u2vboUXo2rJ16Kn3iNtzuxPYimD5mfRTRkV7zFDIUxiwGXxf7ncKbO3VZh7DcKeHkGN1Y1RSR1Q_3KyIwoW0YLyKn22G80MIiVx__BKyrof0MY632nGIwHhAstzV83wEoStOilvUdjSJKPNxx9aAft3baZjboj6P8La47D0rfw5lgqOIHq1TnThxjiAlBctfD78qPrva7lfQmipEPZuFHfrKqJ32T_MbAug2xxmt22tnbKCDBDfw8MUc5v3nprsHYFFewiMuZflFHhISDzjSPs2TIy60TrSISouTfVY-p4IgG_v-eSXage9wzpvjoHQZnMwvZrePEtW62OkG8TmD86uZtWTHlPYo2Prj1OGaXZRGHvd3K4bbdtwOWKq9exXozy83yl_w_U3ich8kLj1LuppKxCmMQVEnPvUSdxqwtkqGidBLqZKTcVLCFqJc
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_script_only_check">
<scan_script_only_check action="INSERT_OR_UPDATE">
<active>true</active>
<category>upgradability</category>
<description>Use Logging Levels: Instead of gs.log(), consider using more appropriate logging levels, such as:&#13;
gs.info() for informational messages.&#13;
gs.warn() for warnings that don’t break functionality but may need attention.&#13;
gs.error() for logging errors that require investigation.</description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>Avoid usage of gs.log()</name>
<priority>3</priority>
<resolution_details/>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (finding, columnValue) {
var matches = columnValue.match(/gs\.log\s*\(/g);
if (matches) {
matches.forEach(function(element) {
finding.increment();
});
}
})(finding, columnValue);]]></script>
<short_description>Avoid usage of gs.log() in prod</short_description>
<sys_class_name>scan_script_only_check</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2024-10-18 02:30:31</sys_created_on>
<sys_id>6b832a7953d1d61000b51901a0490e24</sys_id>
<sys_mod_count>0</sys_mod_count>
<sys_name>Avoid usage of gs.log()</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_script_only_check_6b832a7953d1d61000b51901a0490e24</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2024-10-18 02:30:31</sys_updated_on>
</scan_script_only_check>
<sys_translated_text action="delete_multiple" query="documentkey=6b832a7953d1d61000b51901a0490e24"/>
<sys_es_latest_script action="INSERT_OR_UPDATE">
<id>6b832a7953d1d61000b51901a0490e24</id>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2024-10-18 02:30:31</sys_created_on>
<sys_id>07a5a23953d1d61000b51901a0490e95</sys_id>
<sys_mod_count>0</sys_mod_count>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2024-10-18 02:30:31</sys_updated_on>
<table>scan_script_only_check</table>
<use_es_latest>true</use_es_latest>
</sys_es_latest_script>
</record_update>

0 comments on commit ed3e217

Please sign in to comment.