Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localizations #152

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Add localizations #152

wants to merge 20 commits into from

Conversation

Sella-GH
Copy link
Owner

@Sella-GH Sella-GH commented Aug 8, 2024

No description provided.

@Sella-GH Sella-GH added improvements New feature or request dev-next labels Aug 8, 2024
@Sella-GH Sella-GH added this to the 2.0 Rewrite milestone Aug 8, 2024
@Sella-GH Sella-GH self-assigned this Aug 8, 2024
@Sella-GH Sella-GH changed the title Dev/localization system Add localizations Aug 8, 2024
@Sella-GH Sella-GH marked this pull request as draft August 8, 2024 08:29
Signed-off-by: Sellara <147769367+Sella-GH@users.noreply.github.com>
@Sella-GH Sella-GH modified the milestones: 2.0.0 Rewrite, 2.1.0 Aug 10, 2024
Signed-off-by: Sellara <147769367+Sella-GH@users.noreply.github.com>
@Sella-GH Sella-GH added area-bot Stuff which is related to the bot area-core Stuff which is related to the core library and removed 2.0.0 (Rewrite) labels Aug 16, 2024
Comment on lines +85 to +89
foreach (string excluded in excludedCommands)
{
if (fullSymbolName.EndsWith($"{excluded}.description", StringComparison.OrdinalIgnoreCase))
return true;
}

Check notice

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
- consider filtering the sequence explicitly using '.Where(...)'.
@Sella-GH Sella-GH modified the milestones: 2.1.0, Backlog Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-bot Stuff which is related to the bot area-core Stuff which is related to the core library improvements New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant