Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework stuff #149

Merged
merged 16 commits into from
Aug 4, 2024
Merged

Rework stuff #149

merged 16 commits into from
Aug 4, 2024

Conversation

Sella-GH
Copy link
Owner

@Sella-GH Sella-GH commented Aug 4, 2024

Extracted from #148

@Sella-GH Sella-GH added bug Something isn't working improvements New feature or request area-docker Docker related stuff refactoring Stuff which is related to refactoring dev-next labels Aug 4, 2024
@Sella-GH Sella-GH added this to the 2.0 Rewrite milestone Aug 4, 2024
@Sella-GH Sella-GH self-assigned this Aug 4, 2024
@Sella-GH Sella-GH marked this pull request as ready for review August 4, 2024 15:54
NpgsqlConnectionStringBuilder builder = [];
builder.Host = (string.IsNullOrWhiteSpace(host)) ? "AzzyBot-Db" : host;
builder.Port = port ?? 5432;
builder.Username = (string.IsNullOrWhiteSpace(user)) ? "azzybot" : user;

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "azzybot" flows to the [setter call argument](1) in [Username](2).
builder.ConnectionIdleLifetime = 1200; // 20 minutes

// No password because it can be null when using non-docker
builder.Password = (string.IsNullOrWhiteSpace(password) && HardwareStats.CheckIfDocker) ? "thisIsAzzyB0!P@ssw0rd" : password;

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "thisIsAzzyB0!P@ssw0rd" flows to the [setter call argument](1) in [Password](2).
@Sella-GH Sella-GH merged commit 46c6953 into main Aug 4, 2024
15 of 16 checks passed
@Sella-GH Sella-GH deleted the dev/ReworkingStuff branch August 4, 2024 16:39
@Sella-GH Sella-GH added area-ci Stuff which is related to the CI-Workflows area-database Database related stuff labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ci Stuff which is related to the CI-Workflows area-database Database related stuff area-docker Docker related stuff bug Something isn't working improvements New feature or request refactoring Stuff which is related to refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant