Cancel collect to cursor #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix checks the title of the view, or checks for the Add/Withdraw head items of the top inventory. I wanted to add that second head item check because I'm not sure if the title of Danks can be changed (can't with /itemname even when forced), so that may not be necessary.
Only thing I know may conflict is if someone deliberately names a container "Dank Pack - Tier #", and in which case, the only thing that happens is the cancelation of the event. To me this feels good, although a weird way to handle it, I don't think I have the ability to fix it in a better way :/