Support .L for local labels #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure this doesn't interfere with bls to actual functions? Also probably worth explicitly saying in get_name_inline that this is to avoid .L which isn't accepted by CW inline asm |
Yeah, inline asm building worked fine when I tested with Animal Crossing. I can adjust the comment if you'd like to mention it's to avoid .L syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the bare minimum to support
.Llocal label syntax while still supporting valid inline assembly. Users should set thelabel_prefixsetting in their configuration yaml files to.Lto enable this.