Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenv: Add version 2.1.0 #378

Closed
wants to merge 2 commits into from
Closed

jenv: Add version 2.1.0 #378

wants to merge 2 commits into from

Conversation

nightscape
Copy link
Contributor

@nightscape nightscape commented Mar 24, 2022 •
edited
Loading

Adds https://github.com/FelixSelter/JEnv-for-Windows for managing Java versions.

Due to the tool not being very popular yet, I was recommended to open a PR here.

tech189
tech189 approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@tech189 tech189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation and autoupdate tested.

@nightscape
Copy link
Contributor Author

@tech189 can this be merged?

@tech189 tech189 requested a review from se35710 November 17, 2022 15:40
@tech189 tech189 changed the title jenv: Add version 2.0.0 jenv: Add version 2.1.0 Nov 18, 2022
@se35710
Copy link
Collaborator

se35710 commented Nov 18, 2022

  1. I know this was added to Main before, and then moved here. I think however that its right place is in Extras.

  2. It is however lacking two key features; Switching updates registry (Adding Java path to registry #119) and File association with .jar (Add file association with .jar #112). I was thinking I would update find-java to provide that functionality, but maybe it could be added to jenv too?

  3. It would also be nice to have a more tighter integration with the scoop reset command, so it would switch Java more completely.

I would recommend to add jenv to Extra for now, and then we can work on 2 and 3.

@nightscape nightscape mentioned this pull request Nov 18, 2022
Merged
@nightscape
Copy link
Contributor Author

Moved over to ScoopInstaller/Extras#9779

@nightscape nightscape closed this Nov 18, 2022
@nightscape nightscape deleted the jenv branch November 21, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tech189 tech189 tech189 approved these changes

@se35710 se35710 Awaiting requested review from se35710

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nightscape @se35710 @tech189