Fixes #25

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
SciQLop · Dec 3, 2023 · 14ae6f2 · 14ae6f2
1 parent ec5237c
commit 14ae6f2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pycdfpp/__init__.py b/pycdfpp/__init__.py
@@ -207,6 +207,10 @@ def _add_variable_wrapper(self, name: str, values: np.ndarray or None = None, da
             v, t = _values_view_and_type(values, data_type)
             var = self._add_variable(
                 name=name, values=v, data_type=t, is_nrv=is_nrv, compression=compression)
+        elif data_type is not None:
+            v,t = _values_view_and_type([], data_type)
+            var = self._add_variable(
+                name=name, values=v, data_type=t, is_nrv=is_nrv, compression=compression)
         else:
             var = self._add_variable(
                 name=name, is_nrv=is_nrv, compression=compression)

diff --git a/tests/python_saving/test.py b/tests/python_saving/test.py
@@ -105,5 +105,13 @@ def test_can_save_a_GZ_compressed_CDF(self):
             cdf.compression = pycdfpp.CompressionType.gzip_compression
             self.assertTrue(pycdfpp.save(cdf,f.name))
 
+
+    def test_can_save_a_cdf_with_an_empty_var(self):
+        #https://github.com/SciQLop/CDFpp/issues/25
+        with NamedTemporaryFile() as f:
+            cdf = pycdfpp.CDF()
+            cdf.add_variable("test", data_type=pycdfpp.DataType.CDF_TIME_TT2000)
+            self.assertTrue(pycdfpp.save(cdf,f.name))
+
 if __name__ == '__main__':
     unittest.main()