Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python versions #55

Merged
merged 14 commits into from
Nov 14, 2023
Merged

Conversation

dylanmcreynolds
Copy link
Collaborator

This PR updates the minimum version of python to 3.9. Additionally, it changes the gh action to test 3.9, 3.10 and 3.11.

Along the way, this converts the installation use pyproject.toml

@LAShemilt
Copy link
Collaborator

LAShemilt commented Oct 31, 2023

Love the change to pyproject.toml, much easier to manage. However tests are breaking due to _version.py being changed.

I think all it takes is to update the contents of the pyscicat/__init__.py file which is currently:

from ._version import get_versions

__version__ = get_versions()["version"]
del get_versions

to just

import ._version

Copy link

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine and a good idea.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not get checked in at all, instead add it to .gitignore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep a setup.py with just a setup() call.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that in case people are installing with old versions of pip?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpedersen2
Copy link

The test somehow believes we want python 3.1, which is wrong. I guess the versions in the matrix need quoting, otherwise they are treated as float, giving that result.

@dylanmcreynolds
Copy link
Collaborator Author

That was painful. Apologies if I just blasted you with notification emails. But I got the build to run with these new changes.

Copy link
Collaborator

@LAShemilt LAShemilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , happy to merge

@dylanmcreynolds dylanmcreynolds merged commit fdf3e34 into SciCatProject:main Nov 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants