Message thread #12
Open
Message thread #12
+200
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add message thread, and tests
kubukoz
reviewed
Jul 17, 2018
| @@ -21,7 +21,9 @@ class IncomingMessageProcessor(eventBus: MessageEventBus) extends Actor with Act | |||
| val incomingMessage: IncomingMessage = mType match { | |||
| case MessageType("hello", _) => Hello | |||
| case MessageType("pong", _) => Pong | |||
| case MessageType("message", None) => s.parseJson.convertTo[BaseMessage] | |||
| case MessageType("message", _) => s.parseJson.convertTo[BaseMessage] | |||
There was a problem hiding this comment.
I think this case will match also Some, unless the order is reversed.
| implicit object RepliesJsonReader extends RootJsonFormat[Replies] { | ||
|
|
||
| def read(value: JsValue) = { | ||
| println(value.getClass) |
| println(value.getClass) | ||
| value match { | ||
| case JsArray(replies) => | ||
| val r = replies.map{ x => |
There was a problem hiding this comment.
Let's add a space before {. Also, since x and r aren't very descriptive, we might as well do
Replies {
replies.map(_.convertTo[Reply])
}| } | ||
| } | ||
|
|
||
| implicit object RepliesJsonReader extends RootJsonFormat[Replies] { |
There was a problem hiding this comment.
Do we need a Format? Would Reader be enough?
| override def write(obj: Replies): JsValue = serializationError("not supported") | ||
| } | ||
|
|
||
| implicit object ReplyJsonReader extends RootJsonFormat[Reply] { |
| @@ -10,7 +10,7 @@ class CommandsRecognizerBot(override val bus: MessageEventBus) extends IncomingM | |||
|
|
|||
| def receive: Receive = { | |||
|
|
|||
| case bm@BaseMessage(text, channel, user, dateTime, edited) => | |||
| case bm@BaseMessage(text, channel, user, dateTime, Some(thread_ts),edited) => | |||
There was a problem hiding this comment.
What happens if we get None in place of thread_ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add message thread, and tests. This allows bots to processes and respond in a message thread.