Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] String copies refactor #41

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] String copies refactor #41

wants to merge 2 commits into from

Conversation

mtsokol
Copy link

@mtsokol mtsokol commented Sep 10, 2020 •
edited
Loading

Hi!
While learning I'm trying to address #4. Here I think we avoid few copies, I only looked at replace_fiber_dump and I plan to look at tree_list_widget tomorrow. I still don't get the exact difference in to_owned for our case.

@mtsokol mtsokol requested review from jczuchnowski and vpavkin and removed request for jczuchnowski September 10, 2020 15:04
@vpavkin
Copy link
Contributor

vpavkin commented Sep 10, 2020

Hey @mtsokol ! Great that you're working on this one.
I'll be back on Monday to maybe look closer

@mtsokol
Copy link
Author

mtsokol commented Sep 17, 2020

While getting acquainted with code I changed minor borrow-related bits to avoid more copying - thought they got corrected but might be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpavkin vpavkin Awaiting requested review from vpavkin

@jczuchnowski jczuchnowski Awaiting requested review from jczuchnowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @vpavkin