-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert activation key upgrade scenario to new format #16772
base: master
Are you sure you want to change the base?
Conversation
trigger: test-robottelo |
1 similar comment
trigger: test-robottelo |
trigger: test-robottelo |
trigger: test-robottelo |
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
I have thrown a couple of proposals for improvement but I understand they are out of the scope of this PR and should be rather handled by product teams.
ak = target_sat.api.ActivationKey( | ||
content_view=cv, organization=org, name=f'{test_name}_ak' | ||
).create() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creation should fail since 6.17 (both, CV and LCE, is required). Could we make this creation a bit future-proof by providing it with the Library LCE?
ak = target_sat.api.ActivationKey( | |
content_view=cv, organization=org, name=f'{test_name}_ak' | |
).create() | |
ak = target_sat.api.ActivationKey( | |
content_view=cv, environment=org.library.id, organization=org, name=f'{test_name}_ak' | |
).create() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vsedmik Sure thing, thanks for the feedback. My first thought was that we might want to create a new LCE, but since the post-upgrade section deletes the org at the end, I don't think that's actually necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@synkd That was my first thought too, but didn't want to bother with that and CV promotion. Library will do job too with less pain.
f73933a
to
9ad12b8
Compare
trigger: test-robottelo |
PRT Result
|
9ad12b8
to
da9ab87
Compare
Problem Statement
The activation key upgrade scenario is currently failing and uses the old upgrade test format.
Solution
Convert the test to the new format using the
shared_resource
framework and converting the pre-upgrade test to a pytest fixture.Remove entitlement-related steps as entitlement mode has been removed from Satellite 6.16+.
Related Issues
This test currently fails on the final
org.delete()
step due to SAT-28990.