Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retail Compiler Warning Removal #960

Open
wants to merge 5 commits into
base: Sapphire_Retail
Choose a base branch
from

Commits on Jun 21, 2024

  1. General warning cleanup 1

    * A lot of hit has to do with size_t being unsigned long long in 64 bit.
      - Just explicitly casting for a lot of cases removes the warning
    * Good bit are also the differences in struct definitions to match packets and function definitions
      - Also just cast to fix
    * Used a lot of #pragma warning( disable : 4244/4267 ) for template warnings
    * InviteHandlers.cpp line 118 was definitely a typo bug. Needed assignment "=" instead of "=="
    Reyli committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9435e6e View commit details
    Browse the repository at this point in the history
  2. Warning removals round 2

    Chugged through the rest of the warnings by casting and builds without
    warnings.
    I was going through the intellisense stuff and initializing struct
    variables but like... it stopped working after I restarted Visual
    Studio.
    
    Guess you get what I got.
    Reyli committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5c7d90f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Removing C style casts round 1

    Was told that though removing warnings was good for build, to avoid C
    style casts.
    Reyli committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ed156c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Removing C style casts round 2

    Replacing the stuff I did for warning removal during build from C style
    casts to static_cast.
    Reyli committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6111461 View commit details
    Browse the repository at this point in the history
  2. Reverted struct bracket initialization from Intellisense warning

    Decided Intellisense is weird and inconsistent so if it's not a build
    warning I just ignored it.
    Reyli committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b588f42 View commit details
    Browse the repository at this point in the history