Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arctis Nova 3 support #319

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Add Arctis Nova 3 support #319

merged 3 commits into from
Dec 27, 2023

Conversation

AnErrupTion
Copy link
Contributor

Hello! This PR adds support for the Arctis Nova 3 headset. Alongside this, it adds 2 new capabilities that this headset implements, those being the following:

  • CAP_MICROPHONE_MUTE_LED_BRIGHTNESS
  • CAP_MICROPHONE_VOLUME

The headset also implements the following existing capabilities:

  • CAP_SIDETONE
  • CAP_EQUALIZER_PRESET
  • CAP_EQUALIZER

Closes #294.

Signed-off-by: AnErrupTion <anerruption@disroot.org>
@Sapd
Copy link
Owner

Sapd commented Dec 27, 2023

Thank you!

-o probably has to be replaced with some other letter. As it will be used for output for a further release.
Also I think you forgot to map the long names like --microphone-volume into struct option opts[] = {
We could think about for the new functions, to maybe only map a long name and no short letter at all (can be done by leaving out the letter in getopt_long and implementing the function at case 0:; like done for --timeout)

Signed-off-by: AnErrupTion <anerruption@disroot.org>
@AnErrupTion
Copy link
Contributor Author

Also I think you forgot to map the long names like --microphone-volume into struct option opts[] = {

Yup, haha! Good catch!

We could think about for the new functions, to maybe only map a long name and no short letter at all

That to me sounds like a better bet.

Signed-off-by: AnErrupTion <anerruption@disroot.org>
@Sapd Sapd merged commit 5b9ed65 into Sapd:master Dec 27, 2023
5 checks passed
@AnErrupTion AnErrupTion deleted the arctis-nova-3 branch December 27, 2023 17:51
rpbaptist pushed a commit to rpbaptist/HeadsetControl that referenced this pull request May 31, 2024
* Add Arctis Nova 3 support

Signed-off-by: AnErrupTion <anerruption@disroot.org>

* Fix code style

Signed-off-by: AnErrupTion <anerruption@disroot.org>

* Don't use short letters for new capabilities

Signed-off-by: AnErrupTion <anerruption@disroot.org>

---------

Signed-off-by: AnErrupTion <anerruption@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SteelSeries Arctis Nova 3 support
2 participants