(fix) Expression evaluator should use typeof not instanceof to detect…

… functions (openmrs#1174)
Samstar10 · Oct 22, 2024 · 03c4540 · 03c4540
1 parent 7fbd81f
commit 03c4540
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/framework/esm-expression-evaluator/src/evaluator.test.ts b/packages/framework/esm-expression-evaluator/src/evaluator.test.ts
@@ -172,6 +172,12 @@ describe('OpenMRS Expression Evaluator', () => {
     ).resolves.toBe(2);
   });
 
+  it('Should support mock functions', () => {
+    expect(evaluate('api.getValue()', { api: { getValue: jest.fn().mockImplementation(() => 'value') } })).toBe(
+      'value',
+    );
+  });
+
   it('Should support real-world use-cases', () => {
     expect(
       evaluate('!isEmpty(array)', {

diff --git a/packages/framework/esm-expression-evaluator/src/evaluator.ts b/packages/framework/esm-expression-evaluator/src/evaluator.ts
@@ -468,7 +468,7 @@ function visitCallExpression(expression: jsep.CallExpression, context: Evaluatio
 
   if (!callee) {
     throw `No function named ${expression.callee} is defined in this context`;
-  } else if (!(callee instanceof Function)) {
+  } else if (!(typeof callee === 'function')) {
     throw `${expression.callee} is not a function`;
   }