Update data_tools.onc_json_to_dataset() to ONC API v3 JSON schema and add tests
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the onc_json_to_dataset() function to handle ONC data web service API v3 response JSON schema. Also add unit tests for the function.
Modified onc_json_to_dataset() to include "station" as a dataset attribute from the `parameters.locationCode` item in the JSON response. This is necessary because "station" is the key that the `get_onc_ferry` worker expects to find an element of the metadata it needs under. Updated unit tests to verify that the "station" attribute exists and has the correct value after conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the onc_json_to_dataset() function to handle ONC data web service API v3 response JSON schema. Also add unit tests for the function.