python version upgrade #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsasikumar Please review and merge |
|
Will it not suffice if we just rebuild this so new alpine base image would be used? |
|
@gsasikumar , Hi I am GB. I worked with Renuka on this. We weren’t sure of the side effects it would have by upgrading the base image. From jdk version to dependencies that would change. Do you still recommend upgrading the base image instead? Plus the base image is not just alpine right? It’s some Zulu image based off of alpine. Open to hear your thoughts. |
gandha9394
reviewed
Nov 11, 2023
Dockerfile
Outdated
| @@ -22,8 +23,12 @@ RUN /usr/lib/jvm/zulu11/bin/jlink \ | |||
| --no-header-files \ | |||
| --no-man-pages \ | |||
| --output "$JAVA_MINIMAL" | |||
|
|
|||
| # Second stage, add only our minimal "JRE" distr and our app | |||
| FROM alpine | |||
dheerajkhardwal
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded python version from python3.8 to python3.11
Motivation and Context
To mitigate vulnerabilities in python3.8
Types of changes
Modified one line in dockerfile
Checklist
Need to test with a FIP or FIU