-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying CMakeLists to copy libhwloc-15.dll to the binary folder in Windows, independently #6427
Conversation
… target Signed-off-by: Vedant <vedantnimjed@gmail.com>
Signed-off-by: Vedant <vedantnimjed@gmail.com>
Can one of the admins verify this patch? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Signed-off-by: Vedant <vedantnimjed@gmail.com>
What's the status of this PR? |
I have made all the requested changes. Please review once, in case I have missed something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
References #6394 , #6392
Proposed Changes
libhwloc-15.dll
to the binary folder, directly as a psuedo-targetexamples
psuedo-targetBackground context
#6394 (comment)