Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying CMakeLists to copy libhwloc-15.dll to the binary folder in Windows, independently #6427

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

vrnimje
Copy link
Contributor

@vrnimje vrnimje commented Jan 26, 2024

References #6394 , #6392

Proposed Changes

Background context

#6394 (comment)

… target

Signed-off-by: Vedant <vedantnimjed@gmail.com>
Signed-off-by: Vedant <vedantnimjed@gmail.com>
@vrnimje vrnimje requested a review from hkaiser as a code owner January 26, 2024 11:29
@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

@vrnimje vrnimje changed the title Modified CMakeLists to copy libhwloc-15.dll to the binary folder in Windows, independently Modifying CMakeLists to copy libhwloc-15.dll to the binary folder in Windows, independently Jan 26, 2024
@hkaiser hkaiser added this to the 1.10.0 milestone Jan 26, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

codacy-production bot commented Jan 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8365e76) 201880 171929 85.16%
Head commit (7959daf) 190686 (-11194) 162349 (-9580) 85.14% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6427) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Signed-off-by: Vedant <vedantnimjed@gmail.com>
@hkaiser
Copy link
Member

hkaiser commented Feb 12, 2024

What's the status of this PR?

@vrnimje
Copy link
Contributor Author

vrnimje commented Feb 13, 2024

What's the status of this PR?

I have made all the requested changes. Please review once, in case I have missed something

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit e4a8eb8 into STEllAR-GROUP:master Feb 13, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants