Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developer documentation #34

Merged
merged 15 commits into from
Nov 14, 2023
Merged

Conversation

WanjaTschuorSICKAG
Copy link
Collaborator

No description provided.

Copy link

@gintephSICKAG gintephSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)


How the connection between arrangement and fragment works:

The connection is mediated by the custom element, since that is the point where we are in the parents code context but acually know about a specific child to connect.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "acually"

src/core/direct-functions-plugin/direct-functions.ts Outdated Show resolved Hide resolved
src/core/handshake-plugin/HANDSHAKE.md Outdated Show resolved Hide resolved
src/lib/README.md Outdated Show resolved Hide resolved
src/lib/api/README.md Outdated Show resolved Hide resolved
src/lib/collage-plugin.ts Outdated Show resolved Hide resolved
src/lib/collage-plugin.ts Outdated Show resolved Hide resolved
src/lib/messages.ts Outdated Show resolved Hide resolved
--
this should not break anything, as the recipient is not part of the postMessage body
@WanjaTschuorSICKAG
Copy link
Collaborator Author

Thanks for reviewing @gintephSICKAG

@kirchsuSICKAG kirchsuSICKAG merged commit 1998e20 into main Nov 14, 2023
11 checks passed
@kirchsuSICKAG kirchsuSICKAG deleted the improve-developer-documentation branch November 14, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants