-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom resolution size for main and game #1672
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Raul Galvez <raul.galvez@duke.edu>
Signed-off-by: Raul Galvez <raul.galvez@duke.edu>
Signed-off-by: Raul Galvez <raul.galvez@duke.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thank you so much! I can already give you some feedback on the work you've done.
I did want to ask if changing the engine.cpp and engine.h was alright for this issue? or if I should just use Window::render like #1553 |
@RaulGalvez288 There is openage/libopenage/renderer/window.h Lines 27 to 38 in d09adb0
|
@RaulGalvez288 Are you planning to continue working on this feature? |
Partial fix: #1546
Implemented width and height parameters for main and game start modes.
Still have to add vsync and window modes.