Add support for extended permission rules in conditional policies #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgzones
force-pushed
the
cond_xperm
branch
7 times, most recently
from
1bf68e8
to
da8aa1e
Compare
Use const parameters where applicable to signal immutability. Rename the passed iterator avrule from avrule to narule, to make clear its the neverallow rule to assert against, not the allow rule to check. Drop needless branch in check_assertions(), since in the case avrules is NULL the for loop won't execute and errors will stay at 0, so 0 will be returned regardless. Also there is no call to free() as mentioned in the outdated comment. Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- v3: - use C99 bool where applicable - minor additions v2: add patch
Add support for extended permission rules in conditional policies by
adding a new policy version and adjusting writing and validating
policies accordingly.
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
v5:
- reintroduce correct avrule checking for conditional policies
regressed in v4 via deduplication
v4:
- fix assertion logic on CIL generated policy
- enhance xperm validation
- rebase onto main
v3:
- several assertion logic fixes
v2:
- rebase onto libsepol: Support nlmsg xperms in assertions
- fix assertion checking with xperm av rules in conditional policies
(spotted by Jim, thanks!)
Add support for extended permission rules in conditional policies.
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
v2:
- resbase onto "libsepol: Support nlmsg xperms in assertions" and adjust
resulting (correct) optimization difference
- print extended permission range in hexadecimal
Add support for extended permission rules in conditional policies. Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Indent the printed allow rule that triggered an assertion by two spaces to improve readability. Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- v3: add patch
Add some tests to verify assertion checking works for extended permissions in conditional policies. Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- v3: add patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.