libselinux: add build time option to drop hard dependency on libpcre2 #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare the read-only arguments for comparison and writing const. Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
The function regex_data_create() is only used inside of regex.c, thus do not expose it in the header file regex.h. Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Bump the maximum python version to 3.12 and the maximum ruby version to 3.3 in the GitHub CI. Also bump the setup-python action to v5. Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Currently libselinux links to libpcre2. The regex library is used in the file backend of the selabel database for file context path matching. Some client applications using libselinux might not use that selabel functionality, but they still require to load libpcre2. Examples are dbus-broker and sshd (where openssh only uses the selabel interfaces to create ~/.ssh with the default context). Add a build time option, USE_PCRE2_DLSYM, to drop the hard dependency on libpcre2 and only load it, if actually needed, at runtime via dlopen(3). Since loading the database for the file backend takes a couple of milliseconds performance is not a concern. Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently libselinux links to libpcre2. The regex library is used in
the file backend of the selabel database for file context path matching.
Some client applications using libselinux might not use that selabel
functionality, but they still require to load libpcre2. Examples are
dbus-broker and sshd (where openssh only uses the selabel interfaces to
create ~/.ssh with the default context).
Add a build time option, USE_PCRE2_DLSYM, to drop the hard dependency on
libpcre2 and only load it, if actually needed, at runtime via dlopen(3).
Since loading the database for the file backend takes a couple of
milliseconds performance is not a concern.