-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tracing of SConscript calls #4438
Conversation
Thanks for this. SCons has a historical bias against adding more meaningful environment variables, so that may be an impediment to this precise implementation, but will wait for further feedback. (I do have an experimental branch somewhere that adds a CLI option, as a possible alternative). Whatever the solution, we'll also need to work up some testing to show it works as expected. That doesn't have to happen until the approach is approved. |
Yes. I'd use a --debug= flag to enable this, that'd be mergable. (Also probably helpful to join our discord server to speed the process of getting your PR in shape for merging) |
Thank you gentlemen!
P.S.: Discord blocked on my laptop. Is it really needed to get an app? |
You can connect to discord in your web browser. I'd prefer Do you have access to a mac or linux machine? |
I got Linux, doing my round of rtfm
…________________________________
Von: William Deegan ***@***.***>
Gesendet: Saturday, October 28, 2023 8:56:32 PM
An: SCons/scons ***@***.***>
Cc: Sten Gruener ***@***.***>; Author ***@***.***>
Betreff: Re: [SCons/scons] Adding tracing of scons script calls (PR #4438)
BeSecure! This email comes from outside of ABB. Make sure you verify the sender before clicking any links or downloading/opening attachments.
If this email looks suspicious, report it by clicking 'Report Phishing' button in Outlook or raising a ticket on MyIS.
You can connect to discord in your web browser.
I'd prefer --debug=sconscript than --debug=sconscript-trace
Do you have access to a mac or linux machine, much easier to build the documentation on that than windows.
-Bill
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/SCons/scons/pull/4438*issuecomment-1783897507__;Iw!!NLW3fF9v!LFjV1ogn6cxdfobi_7Q55U8TNfzUaD8g6GEQoBcxptgKP95091XfNbyn6fSWbDPYJi50xtHEU_D-tmPz8SUS7uZVuuM$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQUNYPNA2E7B4J3OZUE7GE3YBVIOBAVCNFSM6AAAAAA6S274DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHA4TONJQG4__;!!NLW3fF9v!LFjV1ogn6cxdfobi_7Q55U8TNfzUaD8g6GEQoBcxptgKP95091XfNbyn6fSWbDPYJi50xtHEU_D-tmPz8SUS7Apc4fo$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Which distro. There's a script in the repo for setting up ubuntu. |
okay, i got stuff installed following git actions workflow
|
I have a handful of fixes and changes and reorganizations to this code to make it mergable.
I think should do it. Here's a summary of the changes:
|
@StenGruener I'm ready to merge my alternate PR unless you have any strong objections? |
Lets continue in #4439 |
@StenGruener - for your next PR, we kinda prefer if you create a branch and submit from that rather than submitting PR from your master branch. |
Thanks for the PR and new functionality! :) |
Contributor Checklist:
CHANGES.txt
(and read theREADME.rst
)Sorry to be so ignorant with respect to checklist, but I wanted to make sure it this PR is able to be accepted at all. I am coming from the discussion here: https://stackoverflow.com/questions/76520575/scons-overriding-sconscript-function-to-get-a-list-all-loaded-sconscripts . So is there hope that our approach can go into the main line?