Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup one test framework test #4428

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Fixup one test framework test #4428

merged 1 commit into from
Oct 14, 2023

Conversation

mwichmann
Copy link
Collaborator

Minor: looking at wrong exceptions for possible rmdir failures. TestCmdTests passes for me with this change.

Limited CI since the framework tests aren't actually run by the CI.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

@mwichmann
Fixup one test framework test [skip appveyor]
aca9467 
Looking at wrong exceptions for possible rmdir failures

Signed-off-by: Mats Wichmann <mats@linux.com>
@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Oct 6, 2023
@bdbaddog bdbaddog merged commit 9fbaa00 into SCons:master Oct 14, 2023
5 of 7 checks passed
@mwichmann mwichmann added this to the 4.6 milestone Oct 15, 2023
@mwichmann mwichmann deleted the testing/fwfix branch October 15, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@mwichmann @bdbaddog