Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With variant dirs SCons creates directories in the build directory per each SCons file. And this can race when parallel SCons tasks are launched in the same directory even if they have separate targets and sconsign files.
The issue code in question is as follows:
_SConscript
performs directory creation.Dir
's_create()
methodMkdirFunc
throughMkdirBuilder
(SCons.Node.Node.build()
)MkdirFunc
function already checks fort.exists()
, so as discussed on the chat a workaround to make this function atomic should be more or less ok.Contributor Checklist:
CHANGES.txt
(and read theREADME.rst
)No documentation or test changes should be necessary for this commit.
CC @mwichmann